Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IR-346: Add Apple SSO support to the IR Engine. #10101

Merged
merged 44 commits into from
Jul 17, 2024
Merged

IR-346: Add Apple SSO support to the IR Engine. #10101

merged 44 commits into from
Jul 17, 2024

Conversation

muradkhateeb78
Copy link
Contributor

@muradkhateeb78 muradkhateeb78 commented Apr 29, 2024 •
edited by hanzlamateen
Loading

@hanzlamateen hanzlamateen changed the title Add Apple SSO support to the IR Engine. IR-346: Add Apple SSO support to the IR Engine. May 16, 2024
@hanzlamateen
Copy link
Member

hanzlamateen commented Jul 16, 2024 •
edited
Loading

@barankyle can you give this a code review.

The changes of this PR are currently deployed on https://ir-engine-qat-dev.theinfinitereality.io/

@barankyle
Copy link
Member

It looks fine, but I don't have an Apple device and seem to have forgotten my password for the Apple ID I do have.

@muradkhateeb78 Are the feathers patches there because Apple does something different with OAuth than everyone else?

@barankyle
Copy link
Member

Got someone else to log in with their Apple ID and it seemed good.

@barankyle barankyle self-requested a review July 17, 2024 00:06
@muradkhateeb78
Copy link
Contributor Author

muradkhateeb78 commented Jul 17, 2024 •
edited
Loading

It looks fine, but I don't have an Apple device and seem to have forgotten my password for the Apple ID I do have.

@muradkhateeb78 Are the feathers patches there because Apple does something different with OAuth than everyone else?

@barankyle Yes, Apple mandates that if you are requesting the user specific information i.e. 'Email OR Name', you have to request it as a form-post response type, which means that this user specific data will be sent back as a POST callback. All other OAuth Providers send the data in a GET callback. The POST callback was not implemented in feathers. We got that implemented in a separate Feathers PR but since the version was 5.0.27 and we are still on 5.0.5, which is a big jump and introduced certain issues when we shifted to 5.0.27, hence we did a patch-package containing only the changes that we needed and kept the version of feathers to be at 5.0.5.

@muradkhateeb78 muradkhateeb78 marked this pull request as ready for review July 17, 2024 04:36
@hanzlamateen hanzlamateen merged commit 4890f8b into dev Jul 17, 2024
25 checks passed
@hanzlamateen hanzlamateen deleted the feat/Enable_Apple_SSO branch July 17, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barankyle barankyle barankyle approved these changes

@hanzlamateen hanzlamateen hanzlamateen approved these changes

@aditya-mitra aditya-mitra Awaiting requested review from aditya-mitra aditya-mitra is a code owner

@SYBIOTE SYBIOTE Awaiting requested review from SYBIOTE SYBIOTE is a code owner

@DanielBelmes DanielBelmes Awaiting requested review from DanielBelmes

@CITIZENDOT CITIZENDOT Awaiting requested review from CITIZENDOT CITIZENDOT is a code owner

@MoizAdnan MoizAdnan Awaiting requested review from MoizAdnan MoizAdnan is a code owner

@hurairahmateen hurairahmateen Awaiting requested review from hurairahmateen hurairahmateen is a code owner

@AidanCaruso AidanCaruso Awaiting requested review from AidanCaruso

@HexaField HexaField Awaiting requested review from HexaField HexaField is a code owner

Assignees
No one assigned
Labels
verified-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@muradkhateeb78 @hanzlamateen @barankyle